#MEDIAWIKI MODULES CODE#

(I originally tried this but -1ing 'Pending usage in our own code in core and bundled extensions:' Pros: Can quickly react to all deprecation warnings in beta cluster.Ĭons: Risk of deprecation warnings showing up in core if not done swiftly.

#MEDIAWIKI MODULES SKIN#

is merged into existing skin modules and removed

#MEDIAWIKI MODULES UPDATE#

Pros: We can update the Wikimedia deployed skins right away by adding a legacy features key new skins lose legacy code.Ĭons: Any skin already using ResourceLoaderSkinModule (unlikely and if they are hopefully they are on top of changes here) will lose legacy feature until they update their own code Some skins may gain legacy styles unexpectedly if previously they were removing them (unlikely). Solution 3: Mark as deprecated and remove from SkinTemplate right away, folding into mediawiki.skinning.* Pros: No changes to core required to pull skins off the dependencyĬons: After is removed from SkinTemplate we'll need to update all skins currently working around getDefaultModules results. We can however simply set the array on the expectation that will soon be folded into ResourceLoaderSkinModule and $modules removed as well.

I'd rather avoid searching and removing from the array as this creates additional technical debt. New skins will get a warning when we mark in resources/Resources.php as deprecated and/or for not overriding skin version.Ĭons: skinVersion could become annoying technical debt SkinTemplate can trigger warnings if skinVersion hasn't been bumped in news skins. Pros: Our skins can update safely without knowledge of internals of SkinTemplate in core. I can see 4 possible solutions to this and would appreciate a clear decision on which one to pursue (at least from :-)). This is a little tricky as there are some explicit usages and some inexplicit usages (skins not overriding Skin:getDefaultModules)

Send warnings to 3rd party skins including.

Vector, Monobook, Modern, CologneBlue to use ResourceLoaderSkinModule. I have lots of possible ways to fix my current goal which is in core will be marked as deprecated. Show related patches Customize query in gerrit Remove the need for Vector's ResourceLoaderLessModule and wgVectorPrintLogo Pull legacy styles from ResourceLoaderSkinModule rather than deprecated moduleĭo not reference in view/resources.php 'for snakview'ĭrop in preparation for its deprecation Get legacy styles from ResourceLoaderSkinModule Move contents of into ResourceLoaderSkinModuleĭrop deprecated (or soon to be deprecated) mediawiki.legacy modules We may in future want to rename this something like for consistency with other skins.

Styles in should be moved to ResourceLoaderSkinModule ( ) and marked as deprecatedĪfter more consideration I think in core should be retained for now for the FallbackSkin and API skin.

in core will be marked as deprecated ( ).

Contents of will be moved to CologneBlue ( ).

Contents of will be moved to Nostalgia skin ( ).

All known impacted skins have been notified about the change to skins.

CologneBlue should use a ResourceLoaderSkinModule.

will be added by Monobook using the ResourceLoaderSkinModule feature legacy.

will be added by Vector using the ResourceLoaderSkinModule feature legacy.Monobook instead of adding will now define their main modules as ResourceLoaderSkinModule.Vector instead of adding will now define their main class e.g.Just as we have deprecated and we should deprecate this module too Acceptance criteria The ResourceLoaderSkinModule class after the introduction of can be used by any skin module to achieve the same as adding the module

Mediawiki modules